New templates: remove TEMPLATE_ROOT setting and old template path
#12144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple way to tell Django to not use the templates from the `readthedocs/templates` directory without removing the files yet. This is a way to test that those files are not used. Related #12105
|
My plan with this PR is to build an development AMI with these changes or, made the changes manually in an already deployed instance, and check the Sentry / New Relic logs for ~1h or similar. We should immediately notice if these templates are used or not.
|
|
We cannot remove the template directory from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple way to tell Django to not use the templates from the
readthedocs/templatesdirectory without removing the files yet.This is a way to test that those files are not used.
Related #12105